Page MenuHomePhabricator
Differential D14560

Add a linter rule for `abstract` methods containing a body
ClosedPublic
Actions

Authored by joshuaspence on Nov 23 2015, 9:05 PM.
Tags
None
Referenced Files
F14029518: D14560.id35224.diff
Fri, Nov 8, 8:46 PM
F14029516: D14560.id35218.diff
Fri, Nov 8, 8:46 PM
F14029515: D14560.diff
Fri, Nov 8, 8:46 PM
F14027699: D14560.diff
Fri, Nov 8, 8:54 AM
F14009433: D14560.id35224.diff
Wed, Oct 30, 5:21 PM
F13980519: D14560.diff
Sat, Oct 19, 11:11 AM
F13980513: D14560.id.diff
Sat, Oct 19, 11:08 AM
F13980505: D14560.id35218.diff
Sat, Oct 19, 11:07 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC72d9013d29dc: Add a linter rule for `abstract` methods containing a body
Summary

abstract methods cannot contain a body.

PHP Fatal error:  Abstract function X::Y() cannot contain body in /home/josh/workspace/github.com/phacility/arcanist/test.php on line 4
Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35218.Nov 23 2015, 9:05 PM
joshuaspence retitled this revision from to Add a linter rule for `abstract` methods containing a body.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 23 2015, 9:05 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 23 2015, 9:09 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2015, 9:09 PM
joshuaspence updated this object.Nov 23 2015, 9:18 PM
joshuaspence edited edge metadata.
Closed by commit rARC72d9013d29dc: Add a linter rule for `abstract` methods containing a body (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 23 2015, 9:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35224

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistAbstractMethodBodyXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistClassMustBeDeclaredAbstractXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistAbstractMethodBodyXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/abstract-method-body/body.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/abstract-method-body/no-body.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/abstract-method-body/non-abstract.lint-test

Loading...
Phabricator · Built by Phacility