Add a linter rule for `abstract private` methods
ClosedPublic
Actions

Authored by joshuaspence on Nov 23 2015, 8:28 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC20e99acf0ad1: Add a linter rule for `abstract private` methods

Summary

Methods cannot be marked as both abstract and private. This language construct will cause a fatal error:

PHP Fatal error:  Abstract function X::Y() cannot be declared private in /home/josh/workspace/github.com/phacility/arcanist/test.php on line 4

Test Plan

Added unit tests.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 9025
Build 10605: Run Core Tests
Build 10604: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	474 ms	ArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
	30 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	15 ms	ArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	27 ms	ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
	11 ms	ArcanistAliasFunctionXHPASTLinterRuleTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 274 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35213.Nov 23 2015, 8:28 PM

joshuaspence retitled this revision from to Add a linter rule for `abstract private` methods.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 23 2015, 8:28 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 23 2015, 8:28 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 23 2015, 8:28 PM

We could, of course, build this into the language definition itself, but I think that this will make a huge mess. Its also be rt of nice that we can parse almost-valid PHP for the purposes of syntax highlighting, as an example.

joshuaspence updated this object.Nov 23 2015, 9:17 PM

joshuaspence edited edge metadata.

Closed by commit rARC20e99acf0ad1: Add a linter rule for `abstract private` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 23 2015, 9:25 PM

This revision was automatically updated to reflect the committed changes.