Page MenuHomePhabricator

Markup project hashtags which begin with (or contain only) digits
ClosedPublic

Authored by epriestley on Nov 23 2015, 1:55 PM.
Tags
None
Referenced Files
F14045701: D14547.diff
Wed, Nov 13, 8:27 AM
F14029182: D14547.id35190.diff
Fri, Nov 8, 7:57 PM
F13982087: D14547.id35184.diff
Oct 19 2024, 9:10 PM
F13968189: D14547.id35184.diff
Oct 16 2024, 7:09 PM
F13955899: D14547.id.diff
Oct 14 2024, 3:27 AM
Unknown Object (File)
Oct 11 2024, 3:18 AM
Unknown Object (File)
Oct 3 2024, 2:14 PM
Unknown Object (File)
Oct 1 2024, 3:10 PM
Subscribers
None

Details

Summary

Fixes T9832. We currently refuse to recognize project hashtags in remarkup if they begin with a digit. This is motivated by attempting to not recognize them if they contain only digits.

I don't think we really gain anything by this. Although most #123 in text are probably not project references, the cost of doing a lookup for them is quite small, and some of them are.

In cases where users use #123 to refer to tasks in an external system, they can use a rule for that with higher precedence than this one or not give their projects conflicting hashtags.

Test Plan
  • This is well-covered by unit tests.
  • Referenced a #3u1, per T9832.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35185.
epriestley retitled this revision from to Markup project hashtags which begin with (or contain only) digits.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Rename a variable for clarity.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2015, 2:37 PM
This revision was automatically updated to reflect the committed changes.