Page MenuHomePhabricator

Add `n_NAMESPACE_NAME` and `n_FUNCTION_NAME` nodes
Needs RevisionPublic

Authored by joshuaspence on Nov 19 2015, 12:21 PM.
Tags
None
Referenced Files
F14028702: D14521.diff
Fri, Nov 8, 3:14 PM
F14021017: D14521.diff
Wed, Nov 6, 4:36 AM
F13962531: D14521.diff
Tue, Oct 15, 10:40 AM
Unknown Object (File)
Oct 3 2024, 2:40 PM
Unknown Object (File)
Sep 27 2024, 7:15 PM
Unknown Object (File)
Sep 6 2024, 5:50 AM
Unknown Object (File)
Sep 5 2024, 8:03 PM
Unknown Object (File)
Aug 26 2024, 1:11 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Currently class names parse as n_CLASS_NAME, but namespace and function names parse as n_SYMBOL_NAME. This diff introduces n_NAMEPSACE_NAME and n_FUNCTION_NAME to allow for better static analysis.

Test Plan

WIP

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 8947
Build 10502: Run Core Tests
Build 10501: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Add `n_NAMESPACE_NAME` and `n_FUNCTION_NAME` nodes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
This revision now requires changes to proceed.Nov 23 2015, 3:28 PM