Paths

Table of Contentst

Differential D14521

Add `n_NAMESPACE_NAME` and `n_FUNCTION_NAME` nodes
Needs RevisionPublic
Actions

Authored by joshuaspence on Nov 19 2015, 12:21 PM.

Tags

None

Referenced Files

	F14021017: D14521.diff
	Wed, Nov 6, 4:36 AM

	F13962531: D14521.diff
	Tue, Oct 15, 10:40 AM

	Unknown Object (File)
	Oct 3 2024, 2:40 PM

	Unknown Object (File)
	Sep 27 2024, 7:15 PM

	Unknown Object (File)
	Sep 6 2024, 5:50 AM

	Unknown Object (File)
	Sep 5 2024, 8:03 PM

	Unknown Object (File)
	Aug 26 2024, 1:11 PM

	Unknown Object (File)
	Aug 20 2024, 10:23 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

Currently class names parse as n_CLASS_NAME, but namespace and function names parse as n_SYMBOL_NAME. This diff introduces n_NAMEPSACE_NAME and n_FUNCTION_NAME to allow for better static analysis.

Test Plan

WIP

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 8947
Build 10502: Run Core Tests
Build 10501: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	36 ms	PHPASTParserTestCase::Unknown Unit Message ("")
	22 ms	PHPASTParserTestCase::Unknown Unit Message ("")
	25 ms	XHPASTTreeTestCase::Unknown Unit Message ("")
	1 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("")
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("")
		View Full Test Results (3 Failed · 318 Passed · 2 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35123.Nov 19 2015, 12:21 PM

joshuaspence retitled this revision from to Add `n_NAMESPACE_NAME` and `n_FUNCTION_NAME` nodes.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 19 2015, 12:21 PM

Herald added a subscriber: epriestley. · View Herald Transcript

joshuaspence updated this object.Nov 19 2015, 9:38 PM

joshuaspence edited edge metadata.

Further progeress

WIP

This revision now requires changes to proceed.Nov 23 2015, 3:28 PM

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

namespace.php.test

4 lines

php-array-dereference.test

8 lines

php-callable-typehint.php.test

2 lines

php-syntax.php.test

97 lines

php-yield.php.test

2 lines

parser_nodes.php

4 lines

support/

xhpast/

generate_nodes.php

4 lines

24 lines

parser.yacc.cpp

5560 lines

parser_nodes.php

4 lines

Diff 35137

src/parser/xhpast/tests/data/namespace.php.test

Loading...

src/parser/xhpast/tests/data/php-array-dereference.test

Loading...

src/parser/xhpast/tests/data/php-callable-typehint.php.test

Loading...

src/parser/xhpast/tests/data/php-syntax.php.test

Loading...

src/parser/xhpast/tests/data/php-yield.php.test

Loading...

src/parser/xhpast/parser_nodes.php

Loading...

support/xhpast/generate_nodes.php

Loading...

support/xhpast/parser.y

Loading...

support/xhpast/parser.yacc.cpp

Loading...

support/xhpast/parser_nodes.php

Loading...