Write a linter rule for unexpected `return` values
ClosedPublic
Actions

Authored by joshuaspence on Nov 18 2015, 11:30 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC3ac313ad1e65: Write a linter rule for unexpected `return` values

Summary

Although it is technically possible to return a value from a PHP constructor, it is rather odd and should be avoided. See some discussion on StackOverflow. Consider the following example:

class SomeClass {
  public function __construct() {
    return 'quack';
  }
}

This doesn't work:

echo new SomeClas();

This, strangely, does work:

echo id(new SomeClass())->__construct();

Test Plan

Added unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35113.Nov 18 2015, 11:30 PM

joshuaspence retitled this revision from to Write a linter rule for unexpected `return` values.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 18 2015, 11:30 PM

Herald added a subscriber: Korvin. · View Herald Transcript

ArcanistUnexpectedReturnValueXHPASTLinterRuleTestCase::testLinter

This one seems like it's probably related? :)

In D14516#163543, @epriestley wrote:

ArcanistUnexpectedReturnValueXHPASTLinterRuleTestCase::testLinter

This one seems like it's probably related? :)

I don't follow?

There are test failures, which you've excused as "Unrelated".

However, one of the test failures is in ArcanistUnexpectedReturnValueXHPASTLinterRuleTestCase, which is introduced in this diff, so it seems like it is related.

In D14516#163545, @epriestley wrote:

There are test failures, which you've excused as "Unrelated".

However, one of the test failures is in ArcanistUnexpectedReturnValueXHPASTLinterRuleTestCase, which is introduced in this diff, so it seems like it is related.

Oh lol