Paths

Table of Contentst

Differential D14496

Add previous and next sibling pointers to `AASTNode`
ClosedPublic
Actions

Authored by joshuaspence on Nov 17 2015, 4:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 4, 1:25 AM

	Unknown Object (File)
	Fri, May 3, 3:33 AM

	Unknown Object (File)
	Mon, Apr 29, 3:23 PM

	Unknown Object (File)
	Wed, Apr 24, 11:18 PM

	Unknown Object (File)
	Tue, Apr 16, 2:57 PM

	Unknown Object (File)
	Tue, Apr 16, 2:57 PM

	Unknown Object (File)
	Tue, Apr 16, 2:57 PM

	Unknown Object (File)
	Tue, Apr 16, 2:57 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHU23edd1b1f443: Add previous and next sibling pointers to `AASTNode`

Summary

Adds AASTNode::$previousSibling and AASTNode::$nextSibling properties. The primary use case is for writing a custom linter rule.

Test Plan

Tested in my custom linter rule.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/parser/xhpast/api/XHPASTNode.php:245	XHP55	Unnecessary `final` Modifier

Unit

Tests Passed

Build Status

Buildable 8879
Build 10389: Run Core Tests
Build 10388: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35069.Nov 17 2015, 4:20 AM

joshuaspence retitled this revision from to Add a `XHPAST::getNamespace` method.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 17 2015, 4:20 AM

Herald added a subscriber: epriestley. · View Herald Transcript

See D14498 instead.

joshuaspence abandoned this revision.Nov 17 2015, 7:30 AM

Actually, this is still generally useful, with some minor modifications.

joshuaspence retitled this revision from Add a `XHPAST::getNamespace` method to Add previous and next sibling pointers to `AASTNode`.Nov 17 2015, 9:32 AM

joshuaspence updated this object.

joshuaspence edited edge metadata.

Repurpose

joshuaspence updated this object.Nov 17 2015, 11:11 AM

joshuaspence edited the test plan for this revision. (Show Details)

Does this affect the time required to construct a large tree? I recall buildTree() being expensive in the past.

In D14496#163239, @epriestley wrote:

Does this affect the time required to construct a large tree? I recall buildTree() being expensive in the past.

It doesn't seem like it does... Using the following script as a benchmark:

P1892 xhpast_tree.php

1	<?php
2
3	require_once __DIR__.'/scripts/__init_script__.php';
4
5	$console = PhutilConsole::getConsole();
6	$iterations = 10;
7	$source = Filesystem::readFile(__DIR__.'/../phabricator/src/__phutil_library_map__.php');
8	$start = microtime(true);
9
10	for ($ii = 0; $ii < $iterations; $ii++) {
11	XHPASTTree::newFromData($source);
12	}
13
14	$end = microtime(true);
15	$duration = $end - $start;
16
17	$console->writeOut("Average: %fs\n", $duration / $iterations);
18	$console->writeOut("Total: %fs\n", $duration);

(The library map from rP is the largest PHP source file that I could easily find at 656K or 8158 lines)

Before

Average: 2.281007s
Total:   22.810069s

After

Average: 2.041991s
Total:   20.419912s

epriestley accepted this revision.Nov 17 2015, 8:35 PM

epriestley added a reviewer: epriestley.

This revision is now accepted and ready to land.Nov 17 2015, 8:35 PM

Closed by commit rPHU23edd1b1f443: Add previous and next sibling pointers to `AASTNode` (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 17 2015, 8:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

aast/

api/

10 lines

16 lines

xhpast/

api/

26 lines

Diff 35069

src/parser/aast/api/AASTNode.php

Loading...

src/parser/aast/api/AASTTree.php

Loading...

src/parser/xhpast/api/XHPASTNode.php

Loading...