Paths

Table of Contentst

Differential D14490

Permanently destroy Almanac properties with the destruction engine
ClosedPublic
Actions

Authored by joshuaspence on Nov 15 2015, 8:36 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP1a84a2fe4bc4: Permanently destroy Almanac properties with the destruction engine

Summary

As suggested in D14461.

Test Plan

Used ./bin/remove destroy on an Almanac service with properties attached, saw entries removed from the phabricator_almanac.almanac_property table.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8864
Build 10365: Run Core Tests
Build 10364: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35054.Nov 15 2015, 8:36 PM

joshuaspence retitled this revision from to Permanently destroy Almanac properties with the destruction engine.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 15 2015, 8:36 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 15 2015, 8:48 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 15 2015, 8:48 PM

I think that we should eventually modularize this behavior because it is becoming rather unwieldy. Offhand, I think that we could do this with some PhabricatorDestructor subclass:

abstract class PhabricatorDestructor extends Phobject {
  abstract public function appliesToObject($object);
  abstract public function destruct($object_phid);
}

Closed by commit rP1a84a2fe4bc4: Permanently destroy Almanac properties with the destruction engine (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 15 2015, 8:58 PM

This revision was automatically updated to reflect the committed changes.

Yeah, agreed. Anywhere we're using instanceof is usually pretty suspicious.

Revision Contents
Changeset List

Path

Size

src/

applications/

system/

engine/

PhabricatorDestructionEngine.php

15 lines

Diff 35054

View Options

src/applications/system/engine/PhabricatorDestructionEngine.php

Permanently destroy Almanac properties with the destruction engineClosedPublicActions