Differential D14486

Remove "async" mode from test engines
ClosedPublic
Actions

Authored by joshuaspence on Nov 15 2015, 8:23 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9131: `arc unit` doesn't output progressive results

Summary

Ref T9131. I have no idea what this mode does or if it was ever used. It looks like it was introduced a very long time ago in D430.

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8854
Build 10348: Run Core Tests
Build 10347: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35044.Nov 15 2015, 8:23 AM

joshuaspence retitled this revision from to Remove "async" mode from test engines.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T9131: `arc unit` doesn't output progressive results.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 15 2015, 8:23 AM

Herald added a subscriber: Korvin. · View Herald Transcript

I think this was a companion to (and perhaps just another name for) "postponed" tests.

This revision is now accepted and ready to land.Nov 15 2015, 4:17 PM

Using "land revision" on D14487 landed and squashed this.

joshuaspence mentioned this in D14487: Remove arguments from unit test engines.Nov 15 2015, 8:11 PM

Revision Contents
Changeset List

Path

Size

src/

unit/

engine/

ArcanistUnitTestEngine.php

10 lines

workflow/

ArcanistUnitWorkflow.php

7 lines

Diff 35044

View Options

src/unit/engine/ArcanistUnitTestEngine.php