Page MenuHomePhabricator
Differential D14421

Clean up Oblivious skin
ClosedPublic
Actions

Authored by chad on Nov 6 2015, 2:58 AM.
Tags
None
Referenced Files
F13136427: D14421.diff
Thu, May 2, 1:59 PM
F13136080: D14421.id34841.diff
Thu, May 2, 12:14 PM
Unknown Object (File)
Thu, Apr 25, 1:15 AM
Unknown Object (File)
Wed, Apr 24, 7:27 PM
Unknown Object (File)
Fri, Apr 19, 3:51 PM
Unknown Object (File)
Fri, Apr 12, 10:07 PM
Unknown Object (File)
Apr 2 2024, 3:43 PM
Unknown Object (File)
Apr 2 2024, 9:54 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9546: Phame "Oblivious" skin a few rough edges
Commits
Restricted Diffusion Commit
rP3a90cb56b475: Clean up Oblivious skin
Summary

Adds Remarkup rules and CSS, cleans up some spacing a color. Ref T9546

Test Plan

Review a blog post list, and a blog

Diff Detail

Repository
rP Phabricator
Branch
oblivious
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8651
Build 10022: Run Core Tests
Build 10021: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34841.Nov 6 2015, 2:58 AM
chad retitled this revision from to Clean up Oblivious.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9546: Phame "Oblivious" skin a few rough edges.
Herald added a subscriber: Korvin. · View Herald TranscriptNov 6 2015, 2:58 AM
chad updated this revision to Diff 34842.Nov 6 2015, 3:00 AM
  • derp
chad added a comment.EditedNov 6 2015, 3:01 AM

I spent about 2 hours trying to "Markup" the Description and properly set the page's Title. I couldn't figure it out, very confusing how these get built.

chad retitled this revision from Clean up Oblivious to Clean up Oblivious skin.Nov 6 2015, 7:34 PM
epriestley accepted this revision.Nov 6 2015, 7:39 PM
epriestley edited edge metadata.

I can take a look at the description/title.

This revision is now accepted and ready to land.Nov 6 2015, 7:39 PM
Closed by commit rP3a90cb56b475: Clean up Oblivious skin (authored by chad, committed by chad). · Explain WhyNov 6 2015, 7:40 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Nov 6 2015, 7:44 PM

awwyiss

Revision Contents
Changeset List

PathSize
externals/
skins/
oblivious/
css/
36 lines
src/
applications/
phame/
skins/
23 lines
17 lines
view/
4 lines

Diff 34842

View Options

externals/skins/oblivious/css/oblivious.css

Loading...
View Options

src/applications/phame/skins/PhameBasicBlogSkin.php

Loading...
View Options

src/applications/phame/skins/PhameBasicTemplateBlogSkin.php

Loading...
View Options

src/applications/phame/view/PhamePostView.php

Loading...
Phabricator · Built by Phacility