Use PHUIDocumentProView in Phame
ClosedPublic
Actions

Authored by chad on Nov 5 2015, 8:09 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T9547: Phame previews are totally unstyled
T9545: Implement a "No Skin" skin for Phame

Commits

Restricted Diffusion Commit
rPe4806631a5b3: Use PHUIDocumentProView in Phame

Summary

Updates "View Post" to use PHUIDocumentViewPro, updates calls to newPage and other minor modernizations. Edit Page updated to show proper document display as well. Ref T9545

Test Plan

Write a blog post, edit it.

Diff Detail

Repository

rP Phabricator

Branch

phame-pro

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8637
Build 10000: Run Core Tests
Build 9999: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34827.Nov 5 2015, 8:09 PM

chad retitled this revision from to Use PHUIDocumentProView in Phame.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9545: Implement a "No Skin" skin for Phame.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 5 2015, 8:09 PM

chad edited the test plan for this revision. (Show Details)Nov 5 2015, 8:10 PM

One very minor inline.

src/applications/phame/controller/post/PhamePostEditController.php
197–200	Prefer `setCrumbs($crumbs)` over passing `$crumbs` as part of the body -- if there are actions in the crumbs, `setCrumbs()` will automatically put them in the mobile menu.
src/applications/phame/controller/post/PhamePostViewController.php
82–84	Crumbs here too.