Updates "View Post" to use PHUIDocumentViewPro, updates calls to newPage and other minor modernizations. Edit Page updated to show proper document display as well. Ref T9545
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T9547: Phame previews are totally unstyled
T9545: Implement a "No Skin" skin for Phame - Commits
- Restricted Diffusion Commit
rPe4806631a5b3: Use PHUIDocumentProView in Phame
Write a blog post, edit it.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
One very minor inline.
src/applications/phame/controller/post/PhamePostEditController.php | ||
---|---|---|
197–200 | Prefer setCrumbs($crumbs) over passing $crumbs as part of the body -- if there are actions in the crumbs, setCrumbs() will automatically put them in the mobile menu. | |
src/applications/phame/controller/post/PhamePostViewController.php | ||
82–84 | Crumbs here too. |