Differential D14401

Check that Phurl alias is unique
ClosedPublic
Actions

Authored by lpriestley on Nov 4 2015, 5:03 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8992: Actually implement an `alias` field on Phurl URL's

Commits

Restricted Diffusion Commit
rP262d7b7780bd: Check that Phurl alias is unique

Summary

Ref T8992, Phurl aliases must be unique. Otherwise throw an error.

Test Plan

Create two Phurl's both with alias 'asdf'. When saving second Phurl, form should show an error about the duplicate alias.

Diff Detail

Repository

rP Phabricator

Branch

phurlduplicatealias

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8600
Build 9942: Run Core Tests
Build 9941: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 34790.Nov 4 2015, 5:03 PM

lpriestley retitled this revision from to Check that Phurl alias is unique.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8992: Actually implement an `alias` field on Phurl URL's.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 4 2015, 5:03 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Nov 4 2015, 5:03 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 4 2015, 5:03 PM

Closed by commit rP262d7b7780bd: Check that Phurl alias is unique (authored by lpriestley, committed by lpriestley). · Explain WhyNov 4 2015, 5:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phurl/

editor/

PhabricatorPhurlURLEditor.php

14 lines

Diff 34790

View Options

src/applications/phurl/editor/PhabricatorPhurlURLEditor.php

Check that Phurl alias is uniqueClosedPublicActions