Paths

Table of Contentst

Differential D14373

Set `$can_edit` for Harbormaster steps
ClosedPublic
Actions

Authored by joshuaspence on Oct 31 2015, 12:22 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP98a301a59b1d: Set `$can_edit` for Harbormaster steps

Summary

Sets the $can_edit value correctly (previously it was hardcoded to true).

Test Plan

Went to http://phabricator.local/harbormaster/step/view/1/ and saw "Edit Step" disabled.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8507
Build 9809: Run Core Tests
Build 9808: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 34700.Oct 31 2015, 12:22 AM

joshuaspence retitled this revision from to Set `$can_edit` for Harbormaster steps.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 31 2015, 12:22 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Oct 31 2015, 1:45 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 31 2015, 1:45 AM

Closed by commit rP98a301a59b1d: Set `$can_edit` for Harbormaster steps (authored by joshuaspence, committed by joshuaspence). · Explain WhyOct 31 2015, 4:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

applications/

harbormaster/

controller/

HarbormasterStepViewController.php

5 lines

Diff 34700

View Options

src/applications/harbormaster/controller/HarbormasterStepViewController.php

Set `$can_edit` for Harbormaster stepsClosedPublicActions