src/unit/engine/NoseTestEngine.php
18	I think this is probably not correct -- if you `cd` into a subdirectory before running `arc land`, I think it will run everything in that subdirectory? (This engine might already have a problem with that anyway, though.) The correct path to use should be `$root = $this->getWorkingCopy()->getProjectRoot();`, I think.

rerun unit tests after updating libphutil

test project root instead of current dir

@epriestley: you're right, now it's better.

The engine shouldn't have a problem with relative directories when running without --everything since it uses git ls-files to find modified python files to test.

So it should be good now :)

epriestley accepted this revision.Oct 28 2015, 9:02 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 28 2015, 9:02 PM

also I got coverage working, just had to run coverage erase to clear my coverage cache

This didn't make it up to the staging area for whatever reason so "land revision" doesn't work, but you should have commit access now. You may need to point your origin at this server instead of GitHub.

20after4 mentioned this in D14363: Make `arc unit` NoseTestEngine work in a sub-dir.Oct 28 2015, 9:59 PM

joshuaspence added a subscriber: joshuaspence.Nov 13 2015, 9:30 AM

Closed by commit rARC607cd77ca10f: Add support for '--everything' in NoseTestEngine (authored by 20after4, committed by 20after4). · Explain WhyJan 25 2016, 10:14 AM

This revision was automatically updated to reflect the committed changes.

20after4 mentioned this in rARC57f6fb59d739: Make `arc unit` NoseTestEngine work in a sub-dir.Jan 25 2016, 10:19 AM