Page MenuHomePhabricator

Add support for '--everything' in NoseTestEngine
ClosedPublic

Authored by 20after4 on Oct 28 2015, 8:42 PM.

Active Operations

Details

Summary

Adds support for running all unit tests with NoseTestEngine.

Test Plan

ran arc unit --everything and got unit test results

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

20after4 retitled this revision from to Add support for '--everything' in NoseTestEngine.
20after4 updated this object.
20after4 edited the test plan for this revision. (Show Details)
20after4 added a reviewer: epriestley.

I think updating libphutil/ will clear the test error, can you try that?

src/unit/engine/NoseTestEngine.php
18

I think this is probably not correct -- if you cd into a subdirectory before running arc land, I think it will run everything in that subdirectory?

(This engine might already have a problem with that anyway, though.)

The correct path to use should be $root = $this->getWorkingCopy()->getProjectRoot();, I think.

20after4 edited edge metadata.

rerun unit tests after updating libphutil

test project root instead of current dir

@epriestley: you're right, now it's better.

The engine shouldn't have a problem with relative directories when running without --everything since it uses git ls-files to find modified python files to test.

So it should be good now :)

epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 28 2015, 9:02 PM
20after4 edited edge metadata.

also I got coverage working, just had to run coverage erase to clear my coverage cache

This didn't make it up to the staging area for whatever reason so "land revision" doesn't work, but you should have commit access now. You may need to point your origin at this server instead of GitHub.

This revision was automatically updated to reflect the committed changes.