Page MenuHomePhabricator

Provide a username and email when running `git merge --squash`
ClosedPublic

Authored by epriestley on Oct 26 2015, 9:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 4:22 PM
Unknown Object (File)
Mon, Dec 2, 9:31 AM
Unknown Object (File)
Mon, Dec 2, 9:31 AM
Unknown Object (File)
Mon, Dec 2, 9:31 AM
Unknown Object (File)
Mon, Dec 2, 9:22 AM
Unknown Object (File)
Sat, Nov 30, 9:01 AM
Unknown Object (File)
Mon, Nov 25, 10:39 AM
Unknown Object (File)
Nov 9 2024, 10:23 AM
Subscribers
None

Details

Summary

Ref T182. This command should never actually generate a commit because --squash prevents that, but git seems to sometimes hit a check for username/email configuration (maybe when merging a non-fastforward?).

Give it some dummy values to placate it. This command shouldn't commit anything so these values should never actually be used.

Test Plan

Diff Detail

Repository
rP Phabricator
Branch
uemail
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8440
Build 9704: Run Core Tests
Build 9703: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Provide a username and email when running `git merge --squash`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, Mnkras.
Mnkras edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2015, 9:11 PM

I feel like a bug should be posted to git about this...

This revision was automatically updated to reflect the committed changes.