Differential D14341

Show lease on Repository Operation detail view and awaken on failures
ClosedPublic
Actions

Authored by epriestley on Oct 26 2015, 5:21 PM.

Tags

None

Referenced Files

	F13085279: D14341.diff
	Wed, Apr 24, 11:46 PM

	Unknown Object (File)
	Sat, Apr 20, 3:17 AM

	Unknown Object (File)
	Fri, Apr 19, 3:49 PM

	Unknown Object (File)
	Thu, Apr 11, 1:25 AM

	Unknown Object (File)
	Sun, Apr 7, 3:02 PM

	Unknown Object (File)
	Sun, Apr 7, 8:37 AM

	Unknown Object (File)
	Thu, Apr 4, 12:21 PM

	Unknown Object (File)
	Mar 23 2024, 5:10 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T182: Commit into repository directly from differential

Commits

Restricted Diffusion Commit
rP2326d5f8d090: Show lease on Repository Operation detail view and awaken on failures

Summary

Ref T182. Couple of minor improvements here:

Show the Drydock lease when viewing a Repository Operation detail screen. This just makes it easier to jump around between relevant objects.
When tasks are waiting for a lease, awaken them when it breaks or is released, not just when it is acquired. This makes the queue move forward faster when errors occur.

Test Plan

Viewed a repository operation and saw a link to the lease.
Did a bad land (intentional merge problem) and got an error in about ~3 seconds instead of ~17.

Diff Detail

Repository

Branch

workmerge3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8419
Build 9677: Run Core Tests
Build 9676: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34610.Oct 26 2015, 5:21 PM

epriestley retitled this revision from to Show lease on Repository Operation detail view and awaken on failures.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T182: Commit into repository directly from differential.

chad accepted this revision.Oct 26 2015, 7:36 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 26 2015, 7:36 PM

Clean update.

Closed by commit rP2326d5f8d090: Show lease on Repository Operation detail view and awaken on failures (authored by epriestley, committed by epriestley). · Explain WhyOct 26 2015, 8:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

controller/

DrydockRepositoryOperationViewController.php

9 lines

storage/

DrydockLease.php

18 lines

DrydockRepositoryOperation.php

9 lines

worker/

DrydockLeaseUpdateWorker.php

18 lines

DrydockRepositoryOperationUpdateWorker.php

2 lines

Diff 34610

src/applications/drydock/controller/DrydockRepositoryOperationViewController.php

Loading...

src/applications/drydock/storage/DrydockLease.php

Loading...

src/applications/drydock/storage/DrydockRepositoryOperation.php

Loading...

src/applications/drydock/worker/DrydockLeaseUpdateWorker.php

Loading...

src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php

Loading...