Page MenuHomePhabricator

Show lease on Repository Operation detail view and awaken on failures
ClosedPublic

Authored by epriestley on Oct 26 2015, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 5:10 PM
Unknown Object (File)
Sun, Mar 10, 4:01 PM
Unknown Object (File)
Mon, Mar 4, 4:42 PM
Unknown Object (File)
Mon, Mar 4, 4:42 PM
Unknown Object (File)
Mon, Mar 4, 4:42 PM
Unknown Object (File)
Mon, Mar 4, 4:42 PM
Unknown Object (File)
Mon, Mar 4, 4:42 PM
Unknown Object (File)
Thu, Feb 29, 1:15 AM
Subscribers
None

Details

Summary

Ref T182. Couple of minor improvements here:

  • Show the Drydock lease when viewing a Repository Operation detail screen. This just makes it easier to jump around between relevant objects.
  • When tasks are waiting for a lease, awaken them when it breaks or is released, not just when it is acquired. This makes the queue move forward faster when errors occur.
Test Plan
  • Viewed a repository operation and saw a link to the lease.
  • Did a bad land (intentional merge problem) and got an error in about ~3 seconds instead of ~17.

Diff Detail

Repository
rP Phabricator
Branch
workmerge3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8434
Build 9695: Run Core Tests
Build 9694: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Show lease on Repository Operation detail view and awaken on failures.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2015, 7:36 PM
epriestley edited edge metadata.

Clean update.

This revision was automatically updated to reflect the committed changes.