Page MenuHomePhabricator

Show lease on Repository Operation detail view and awaken on failures
ClosedPublic

Authored by epriestley on Oct 26 2015, 5:21 PM.

Details

Summary

Ref T182. Couple of minor improvements here:

  • Show the Drydock lease when viewing a Repository Operation detail screen. This just makes it easier to jump around between relevant objects.
  • When tasks are waiting for a lease, awaken them when it breaks or is released, not just when it is acquired. This makes the queue move forward faster when errors occur.
Test Plan
  • Viewed a repository operation and saw a link to the lease.
  • Did a bad land (intentional merge problem) and got an error in about ~3 seconds instead of ~17.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 34610.Oct 26 2015, 5:21 PM
epriestley retitled this revision from to Show lease on Repository Operation detail view and awaken on failures.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Oct 26 2015, 7:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 26 2015, 7:36 PM
epriestley updated this revision to Diff 34625.Oct 26 2015, 8:00 PM
epriestley edited edge metadata.

Clean update.

This revision was automatically updated to reflect the committed changes.