Differential D14336

Make WorkingCopy build step slightly more durable
ClosedPublic
Actions

Authored by epriestley on Oct 25 2015, 8:53 PM.

Details

Reviewers

chad

Maniphest Tasks

T9631: Don't crash when users fail to specify additional working copies

Commits

Restricted Diffusion Commit
rP43569d4e278c: Make WorkingCopy build step slightly more durable

Summary

Fixes T9631. Build steps created before I added this option may not have it specified, which could throw later. Make handling a little more robust.

Test Plan

Will ask @yelirekim to report back.

Diff Detail

Repository

rP Phabricator

Branch

stepdurable

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8409
Build 9663: Run Core Tests
Build 9662: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34600.Oct 25 2015, 8:53 PM

epriestley retitled this revision from to Make WorkingCopy build step slightly more durable.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9631: Don't crash when users fail to specify additional working copies.

epriestley added a subscriber: yelirekim.

chad accepted this revision.Oct 25 2015, 8:53 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 25 2015, 8:53 PM

Closed by commit rP43569d4e278c: Make WorkingCopy build step slightly more durable (authored by epriestley, committed by epriestley). · Explain WhyOct 25 2015, 9:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

step/

HarbormasterLeaseWorkingCopyBuildStepImplementation.php

3 lines

Diff 34600

View Options

src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php

Make WorkingCopy build step slightly more durableClosedPublicActions