Fixes T9592.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T9592: "Create subtask" is not greyed out for logged-out users
- Commits
- Restricted Diffusion Commit
rP0e8ed0c61684: Desactivate subtask when logged out.
Log out ! Navigates to a task. See the add button grey-ed out !
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
@tycho.tatitscheff, you wrote this in your test plan:
Log out ! Navigates to a task. See the add button grey-ed out !
Did you actually do this?
That is, did you introduce the fatal after testing, or did you not actually test the change?
Comment Actions
I did :
- write the diff
- commit it
- patched my remote non-production phab, tested it
- create the revision, get linting issue, canceling the rev, refactor it and indent it properly (this introduces the error), amend it to existing, send skiping unit (since my laptop mysql was not working since update and since i was on travel, it wasn't easy to reinstall it)
- since i was on travel, I thought you won't send it as it is (I should have had the WIP on title) since unit was skipped
- when i reconnected, cathed my error, audit it , contact you on irc, created a diff but vlada was faster
So yes I tested it before, but anyway it is all my bad. I should have put "WIP" in title, retest it after amending.
Sorry for that.
Comment Actions
In hindsight, we'll only give out "Contributor" to net-positive improvements to Phabricator. No worries though, last I checked there are probably dozens of this non-disabled buttons around Phabricator. Easy pickins'.