Page MenuHomePhabricator
Differential D14284

Add a "Token" Credential type
ClosedPublic
Actions

Authored by epriestley on Oct 15 2015, 1:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 3:45 PM
Unknown Object (File)
Wed, Apr 10, 3:45 PM
Unknown Object (File)
Sat, Apr 6, 7:59 AM
Unknown Object (File)
Sat, Apr 6, 7:53 AM
Unknown Object (File)
Fri, Apr 5, 12:24 AM
Unknown Object (File)
Mon, Apr 1, 2:04 PM
Unknown Object (File)
Mon, Apr 1, 8:28 AM
Unknown Object (File)
Sun, Mar 31, 2:50 AM
View All Files
Subscribers
joshuaspence

Details

Reviewers
chad
Maniphest Tasks
T9456: Evaluate upstream support for third-party build systems
Commits
Restricted Diffusion Commit
rP63d755723bcf: Add a "Token" Credential type
Summary

Ref T9456. This is just a convenience type for things like API tokens, to make it harder for users to make mistakes and keep SSH keys out of the dropdown for "choose your API token".

Test Plan

Screen Shot 2015-10-14 at 6.36.46 PM.png (903×1 px, 171 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34482.Oct 15 2015, 1:40 AM
epriestley retitled this revision from to Add a "Token" Credential type.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9456: Evaluate upstream support for third-party build systems.
chad accepted this revision.Oct 15 2015, 1:42 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 15 2015, 1:42 AM
joshuaspence added a subscriber: joshuaspence.Nov 13 2015, 10:11 AM
epriestley updated this revision to Diff 35249.Nov 25 2015, 3:16 PM
epriestley edited edge metadata.
  • Rebase after possible CircleCI changes.
epriestley updated this revision to Diff 37363.Mar 19 2016, 9:49 PM
  • Rebase.
  • Handle cases where a credential type no longer exists more cleanly.
epriestley mentioned this in T9456: Evaluate upstream support for third-party build systems.Mar 19 2016, 10:51 PM
Closed by commit rP63d755723bcf: Add a "Token" Credential type (authored by epriestley, committed by epriestley). · Explain WhyMar 22 2016, 7:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37384

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

Loading...
View Options

src/applications/passphrase/credentialtype/PassphraseTokenCredentialType.php

Loading...
View Options

src/applications/passphrase/editor/PassphraseCredentialTransactionEditor.php

Loading...
View Options

src/applications/passphrase/keys/PassphraseAbstractKey.php

Loading...
View Options

src/applications/passphrase/query/PassphraseCredentialQuery.php

Loading...
View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
Phabricator · Built by Phacility