Page MenuHomePhabricator
Differential D14283

Link Timeline image to profile
ClosedPublic
Actions

Authored by chad on Oct 14 2015, 9:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 7, 3:47 PM
Unknown Object (File)
Tue, Jan 7, 3:45 PM
Unknown Object (File)
Tue, Jan 7, 3:29 PM
Unknown Object (File)
Tue, Dec 31, 3:23 PM
Unknown Object (File)
Tue, Dec 31, 2:55 PM
Unknown Object (File)
Mon, Dec 30, 12:28 AM
Unknown Object (File)
Wed, Dec 18, 3:06 AM
Unknown Object (File)
Dec 10 2024, 7:40 PM
View All Files
Subscribers
joshuaspence
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9336: Link profile image in feed
Commits
Restricted Diffusion Commit
rPf1552f54a056: Link Timeline image to profile
Summary

Ref T9336. Links the timeline photo to user profile. Presume this always exists?

Test Plan

Review a few timelines, click on heads.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34478.Oct 14 2015, 9:51 PM
chad retitled this revision from to Link Timeline image to profile.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9336: Link profile image in feed.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 14 2015, 9:51 PM
epriestley accepted this revision.Oct 14 2015, 10:03 PM
epriestley edited edge metadata.

The only unusual case I can come up with is that I think this will link applications (like "Harbormaster failed to build...", "Herald updated...") to the application base page (/harbormaster/, /herald/). Might be confusing/weird? But doesn't seem too unreasonable to me, really.

This revision is now accepted and ready to land.Oct 14 2015, 10:03 PM
epriestley added a comment.Oct 14 2015, 10:04 PM

I guess they probably never actually render with user images (although maybe they should since feed stories by them look weird).

chad updated this revision to Diff 34479.Oct 14 2015, 10:10 PM
chad edited edge metadata.
  • sanity check
Closed by commit rPf1552f54a056: Link Timeline image to profile (authored by chad, committed by chad). · Explain WhyOct 14 2015, 11:28 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a subscriber: joshuaspence.Oct 15 2015, 8:26 AM

Either I never noticed it before... Or this diff caused avatars to be displayed on desktop notifications

epriestley mentioned this in T9336: Link profile image in feed.Dec 11 2015, 11:41 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
phui/
3 lines
webroot/
rsrc/
css/
phui/
1 line

Diff 34481

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUITimelineEventView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Phabricator · Built by Phacility