Page MenuHomePhabricator

Link Timeline image to profile
ClosedPublic

Authored by chad on Oct 14 2015, 9:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 1, 2:35 AM
Unknown Object (File)
Wed, Mar 27, 3:43 PM
Unknown Object (File)
Wed, Mar 27, 3:43 PM
Unknown Object (File)
Mar 4 2024, 7:46 PM
Unknown Object (File)
Mar 4 2024, 6:38 PM
Unknown Object (File)
Mar 4 2024, 6:38 PM
Unknown Object (File)
Feb 13 2024, 8:16 PM
Unknown Object (File)
Jan 9 2024, 11:03 AM

Details

Reviewers
epriestley
Maniphest Tasks
T9336: Link profile image in feed
Commits
Restricted Diffusion Commit
rPf1552f54a056: Link Timeline image to profile
Summary

Ref T9336. Links the timeline photo to user profile. Presume this always exists?

Test Plan

Review a few timelines, click on heads.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Link Timeline image to profile.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

The only unusual case I can come up with is that I think this will link applications (like "Harbormaster failed to build...", "Herald updated...") to the application base page (/harbormaster/, /herald/). Might be confusing/weird? But doesn't seem too unreasonable to me, really.

This revision is now accepted and ready to land.Oct 14 2015, 10:03 PM

I guess they probably never actually render with user images (although maybe they should since feed stories by them look weird).

chad edited edge metadata.
  • sanity check
This revision was automatically updated to reflect the committed changes.

Either I never noticed it before... Or this diff caused avatars to be displayed on desktop notifications