Page MenuHomePhabricator

Add custom Cows and Figlet directories to .gitignore
ClosedPublic

Authored by epriestley on Oct 9 2015, 3:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 8:28 PM
Unknown Object (File)
Wed, Nov 20, 10:05 AM
Unknown Object (File)
Mon, Nov 18, 6:15 PM
Unknown Object (File)
Fri, Nov 15, 5:49 AM
Unknown Object (File)
Mon, Nov 11, 5:51 AM
Unknown Object (File)
Sun, Nov 10, 10:24 AM
Unknown Object (File)
Sun, Nov 10, 10:18 AM
Unknown Object (File)
Sat, Nov 9, 10:06 PM
Subscribers

Details

Summary

These directories didn't get added to .gitignore, but should be.

Test Plan
  • Touched a dummy file in each directory.
  • Ran git status.
  • Didn't see the file show up.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add custom Cows and Figlet directories to .gitignore.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, cspeckmim.
chad edited edge metadata.

suchwow

This revision is now accepted and ready to land.Oct 9 2015, 3:20 AM

I think those folders have README files -- maybe just *.cow and *.flf?

In Git, at least, a file being tracked punches through the ignore list, so it un-ignores anything you've explicitly added to the repo by default. So the READMEs should work as desired (e.g., if I change one, git does pick up the change, even though it's technically covered by a .gitignore pattern).

This revision was automatically updated to reflect the committed changes.

Ah ok! Mercurial behaves similarly now that I think about it -- It's caused confusion previously when certain developers manually added .DS_Store turds when all should be ignored by .hgignore.

Oh and I didn't mean to suggest /*.cow but rather /resources/cows/custom/*.cow -- there must be blessed cows in the repository.

Personally I'd prefer this:

resources/cows/custom/.gitignore
*
resources/figlet/custom/.gitignore
*

But I have no idea why...

_______ < Moo > ------- \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || ||
__ ___ _ _ _ __ _ \ \ / / |__ __ _| |_ | |_| |__ ___ / _(_) __ _ \ \ /\ / /| '_ \ / _` | __| | __| '_ \ / _ \ | |_| |/ _` | \ V V / | | | | (_| | |_ | |_| | | | __/ | _| | (_| | \_/\_/ |_| |_|\__,_|\__| \__|_| |_|\___| |_| |_|\__, | |___/