Page MenuHomePhabricator

Garbage collect Drydock logs after 30 days
ClosedPublic

Authored by epriestley on Sep 30 2015, 2:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 5:01 AM
Unknown Object (File)
Thu, Dec 12, 11:45 PM
Unknown Object (File)
Wed, Dec 11, 11:20 PM
Unknown Object (File)
Fri, Dec 6, 11:30 AM
Unknown Object (File)
Thu, Nov 28, 7:52 AM
Unknown Object (File)
Tue, Nov 26, 2:22 PM
Unknown Object (File)
Tue, Nov 26, 6:03 AM
Unknown Object (File)
Sat, Nov 23, 11:28 PM
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9252: Unprototype Drydock (v1)
Commits
Restricted Diffusion Commit
rP06f927250290: Garbage collect Drydock logs after 30 days
Summary

Ref T9252. Drydock logs are almost exclusively useful as a diagnostic tool for debugging immediate problems, so GC them fairly aggressively.

(I expect 99% of the usefulness of these logs to be within the first 24 hours, basically "why isn't my thing working". I can't really think of any cases where having old logs would be useful.)

Test Plan
  • Ran GC, saw it hit the log table (with no effect).
  • Changed TTL from 30 days to 30 seconds, ran GC, saw it wipe recent logs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Garbage collect Drydock logs after 30 days.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2015, 4:26 PM
This revision was automatically updated to reflect the committed changes.