HomePhabricator

Move Drydock logs to PHIDs and increased structure

Description

Move Drydock logs to PHIDs and increased structure

Summary:
Ref T9252. Several general changes here:

  • Moves logs to use PHIDs instead of IDs. This generally improves flexibility (for example, it's a lot easier to render handles).
  • Adds blueprintPHID to logs. Although you can usually figure this out from the leasePHID or resourcePHID, it lets us query relevant logs on Blueprint views.
  • Instead of making logs a top-level object, make them strictly a sub-object of Blueprints, Resources and Leases. So you go Drydock > Lease > Logs, etc., to get to logs.
    • I might restore the "everything" view eventually, but it doesn't interact well with policies and I'm not sure it's very useful. A policy-violating bin/drydock log might be cleaner.
  • Policy-wise, we always show you that logs exist, we just don't show you log content if it's about something you can't see. This is similar to seeing restricted handles in other applications.
  • Instead of just having a message, give logs "type" + "data". This will let logs be more structured and translatable. This is similar to recent changes to Herald which seem to have worked well.

Test Plan:
Added some placeholder log writes, viewed those logs in the UI.

Screen Shot 2015-09-30 at 7.42.42 AM.png (989×1 px, 171 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9252

Differential Revision: https://secure.phabricator.com/D14196

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Oct 1 2015, 3:06 PM
Reviewer
chad
Differential Revision
D14196: Move Drydock logs to PHIDs and increased structure
Parents
rP98006f2cf365: Update Asana Logo
Branches
Unknown
Tags
Unknown
Tasks
T9252: Unprototype Drydock (v1)
Build Status
Buildable 8123
Build 9273: Run Core Tests