Page MenuHomePhabricator
Differential D14181

Fix issue with "Publish/Notify" handling in repositories
ClosedPublic
Actions

Authored by epriestley on Sep 28 2015, 6:02 PM.
Tags
None
Referenced Files
F15468533: D14181.id34260.diff
Fri, Apr 4, 1:45 AM
F15468310: D14181.id34259.diff
Thu, Apr 3, 11:04 PM
F15464370: D14181.id.diff
Wed, Apr 2, 8:55 AM
F15463961: D14181.id34259.diff
Wed, Apr 2, 5:04 AM
F15462464: D14181.diff
Tue, Apr 1, 3:14 PM
F15456629: D14181.id.diff
Sun, Mar 30, 10:51 AM
F15407288: D14181.id34259.diff
Tue, Mar 18, 4:42 PM
F15390890: D14181.diff
Sat, Mar 15, 7:13 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8728: Setting "Notify/Publish" to "Disable Notifications, Feed and Herald" in Diffusion doesn't actually work
Commits
Restricted Diffusion Commit
rP6d7b78f791f0: (stable) Fix issue with "Publish/Notify" handling in repositories
rP0438a481e113: Fix issue with "Publish/Notify" handling in repositories
Summary

Fixes T8728. As far as I can tell, I simply got this wrong in D11826. This is not the proper name for the preference.

That change primarily focused on the "spammy junk during import" issue, and the code did get the importing flag right. It looks like my testing in D11827 focused on "during import" and just missed this case.

Test Plan

Grepped for disable-herald. Grepped for herald-disable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34259.Sep 28 2015, 6:02 PM
epriestley retitled this revision from to Fix issue with "Publish/Notify" handling in repositories.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8728: Setting "Notify/Publish" to "Disable Notifications, Feed and Herald" in Diffusion doesn't actually work.
chad accepted this revision.Sep 28 2015, 6:16 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2015, 6:16 PM
Closed by commit rP0438a481e113: Fix issue with "Publish/Notify" handling in repositories (authored by epriestley, committed by epriestley). · Explain WhySep 28 2015, 6:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
storage/
2 lines

Diff 34260

View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility