Page MenuHomePhabricator

Fix issue with "Publish/Notify" handling in repositories
ClosedPublic

Authored by epriestley on Sep 28 2015, 6:02 PM.
Tags
None
Referenced Files
F19154166: D14181.diff
Thu, Dec 11, 1:42 PM
F18854597: D14181.id.diff
Nov 1 2025, 12:23 AM
F18835222: D14181.id.diff
Oct 26 2025, 2:20 PM
F18751009: D14181.id34259.diff
Oct 4 2025, 9:32 AM
F18743674: D14181.id34260.diff
Oct 3 2025, 12:26 AM
F18712756: D14181.diff
Sep 29 2025, 5:31 AM
F18684566: D14181.diff
Sep 26 2025, 9:42 AM
F18585898: D14181.id34260.diff
Sep 11 2025, 4:47 PM
Subscribers
None

Details

Summary

Fixes T8728. As far as I can tell, I simply got this wrong in D11826. This is not the proper name for the preference.

That change primarily focused on the "spammy junk during import" issue, and the code did get the importing flag right. It looks like my testing in D11827 focused on "during import" and just missed this case.

Test Plan

Grepped for disable-herald. Grepped for herald-disable.

Diff Detail

Repository
rP Phabricator
Branch
hdisable1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8076
Build 9184: [Placeholder Plan] Wait for 30 Seconds
Build 9183: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix issue with "Publish/Notify" handling in repositories.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 28 2015, 6:16 PM
This revision was automatically updated to reflect the committed changes.