Page MenuHomePhabricator

Implement more consistent publishing rules for repositories
ClosedPublic

Authored by epriestley on Feb 19 2015, 5:18 PM.
Tags
None
Referenced Files
F17818887: D11826.id28500.diff
Sat, Jul 26, 12:45 AM
Unknown Object (File)
May 9 2025, 6:14 PM
Unknown Object (File)
May 8 2025, 11:23 AM
Unknown Object (File)
May 5 2025, 7:44 PM
Unknown Object (File)
Apr 27 2025, 5:54 PM
Unknown Object (File)
Apr 23 2025, 7:56 PM
Unknown Object (File)
Apr 21 2025, 1:14 AM
Unknown Object (File)
Apr 20 2025, 2:14 AM
Subscribers

Details

Summary

Ref T7298. We are currently inconsistent about when we publish feed, email, notifications, audits and Herald rules.

Specifically, there are two settings which impact these things:

  • The "importing" flag, which is set when we're importing old commits.
  • The "herald-disabled" flag, which was expanded in scope some time ago and now actually means "disable publishing".

Various parts of the pipeline were checking only one of these flags. Instead, all of them should check both.

(For example, we should never email users about importing repositories, nor trigger audits on them.)

Test Plan

See next revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable