Differential D14169

Fix Herald rule actions on empty custom PHID fields
ClosedPublic
Actions

Authored by epriestley on Sep 25 2015, 5:37 PM.

Details

Reviewers

chad

Maniphest Tasks

T9260: HeraldAdapter throws exception on empty user custom field.

Commits

Restricted Diffusion Commit
rP99d972fc8187: Fix Herald rule actions on empty custom PHID fields

Summary

Fixes T9260. That task has a good description of the issue.

Test Plan

Followed steps in T9260 to reproduce the issue. Applied patch; issue went away.

Diff Detail

Repository

rP Phabricator

Branch

hcustomhpid

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8060
Build 9154: [Placeholder Plan] Wait for 30 Seconds
Build 9153: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34226.Sep 25 2015, 5:37 PM

epriestley retitled this revision from to Fix Herald rule actions on empty custom PHID fields.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9260: HeraldAdapter throws exception on empty user custom field..

chad accepted this revision.Sep 25 2015, 9:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 25 2015, 9:03 PM

Closed by commit rP99d972fc8187: Fix Herald rule actions on empty custom PHID fields (authored by epriestley, committed by epriestley). · Explain WhySep 25 2015, 10:00 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).Sep 27 2015, 1:50 PM

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

customfield/

standard/

PhabricatorStandardCustomFieldPHIDs.php

10 lines

Diff 34226

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

Fix Herald rule actions on empty custom PHID fieldsClosedPublicActions