Page MenuHomePhabricator
Differential D14166

Allow lint codes to be up to 128 bytes long
ClosedPublic
Actions

Authored by epriestley on Sep 25 2015, 5:07 PM.
Tags
None
Referenced Files
F17968112: D14166.diff
Fri, Aug 1, 1:03 PM
F17834173: D14166.id34227.diff
Sat, Jul 26, 2:10 PM
F17834172: D14166.id34223.diff
Sat, Jul 26, 2:10 PM
F17833700: D14166.id.diff
Sat, Jul 26, 1:47 PM
F17755955: D14166.diff
Tue, Jul 22, 1:29 PM
Unknown Object (File)
May 30 2025, 9:33 AM
Unknown Object (File)
May 30 2025, 4:53 AM
Unknown Object (File)
May 29 2025, 10:37 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9145: Exception on arc diff with PHPCS linter
Commits
Restricted Diffusion Commit
rP8ce90a7c4287: Allow lint codes to be up to 128 bytes long
Summary

Fixes T9145. We currently restrict lint codes to 32 bytes, but PHPCS generates codes like "PHPCS.E.PEAR.Comments.Messages.Line.TooLong".

These codes seem reasonable as codes, and we don't currently have any key-length problems or other technical concerns with simply raising the size of this column.

Test Plan

Ran bin/storage upgrade to pick up adjustments.

Diff Detail

Repository
rP Phabricator
Branch
code128
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8057
Build 9148: [Placeholder Plan] Wait for 30 Seconds
Build 9147: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34223.Sep 25 2015, 5:07 PM
epriestley retitled this revision from to Allow lint codes to be up to 128 bytes long.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9145: Exception on arc diff with PHPCS linter.
chad accepted this revision.Sep 25 2015, 5:09 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2015, 5:09 PM
Closed by commit rP8ce90a7c4287: Allow lint codes to be up to 128 bytes long (authored by epriestley, committed by epriestley). · Explain WhySep 25 2015, 5:42 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T12981: Explicitly limit lint and unit test names to 255 characters.Sep 12 2017, 7:08 PM

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
storage/
build/
2 lines

Diff 34223

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLintMessage.php

Loading...
Phabricator · Built by Phacility