Page MenuHomePhabricator

Allow lint codes to be up to 128 bytes long
ClosedPublic

Authored by epriestley on Sep 25 2015, 5:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 20 2024, 7:55 PM
Unknown Object (File)
Jan 26 2024, 7:40 AM
Unknown Object (File)
Jan 6 2024, 12:27 PM
Unknown Object (File)
Dec 30 2023, 5:48 PM
Unknown Object (File)
Dec 26 2023, 7:23 PM
Unknown Object (File)
Dec 24 2023, 5:36 PM
Unknown Object (File)
Dec 23 2023, 6:23 AM
Unknown Object (File)
Dec 18 2023, 4:16 PM
Subscribers
None

Details

Summary

Fixes T9145. We currently restrict lint codes to 32 bytes, but PHPCS generates codes like "PHPCS.E.PEAR.Comments.Messages.Line.TooLong".

These codes seem reasonable as codes, and we don't currently have any key-length problems or other technical concerns with simply raising the size of this column.

Test Plan

Ran bin/storage upgrade to pick up adjustments.

Diff Detail

Repository
rP Phabricator
Branch
code128
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8057
Build 9148: [Placeholder Plan] Wait for 30 Seconds
Build 9147: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow lint codes to be up to 128 bytes long.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2015, 5:09 PM
This revision was automatically updated to reflect the committed changes.