Page MenuHomePhabricator

Allow lint codes to be up to 128 bytes long
ClosedPublic

Authored by epriestley on Sep 25 2015, 5:07 PM.
Tags
None
Referenced Files
F17834173: D14166.id34227.diff
Sat, Jul 26, 2:10 PM
F17834172: D14166.id34223.diff
Sat, Jul 26, 2:10 PM
F17833700: D14166.id.diff
Sat, Jul 26, 1:47 PM
F17755955: D14166.diff
Tue, Jul 22, 1:29 PM
Unknown Object (File)
May 30 2025, 9:33 AM
Unknown Object (File)
May 30 2025, 4:53 AM
Unknown Object (File)
May 29 2025, 10:37 AM
Unknown Object (File)
May 6 2025, 2:22 AM
Subscribers
None

Details

Summary

Fixes T9145. We currently restrict lint codes to 32 bytes, but PHPCS generates codes like "PHPCS.E.PEAR.Comments.Messages.Line.TooLong".

These codes seem reasonable as codes, and we don't currently have any key-length problems or other technical concerns with simply raising the size of this column.

Test Plan

Ran bin/storage upgrade to pick up adjustments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow lint codes to be up to 128 bytes long.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2015, 5:09 PM
This revision was automatically updated to reflect the committed changes.