Page MenuHomePhabricator

Allow lint codes to be up to 128 bytes long
ClosedPublic

Authored by epriestley on Sep 25 2015, 5:07 PM.

Details

Summary

Fixes T9145. We currently restrict lint codes to 32 bytes, but PHPCS generates codes like "PHPCS.E.PEAR.Comments.Messages.Line.TooLong".

These codes seem reasonable as codes, and we don't currently have any key-length problems or other technical concerns with simply raising the size of this column.

Test Plan

Ran bin/storage upgrade to pick up adjustments.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 34223.Sep 25 2015, 5:07 PM
epriestley retitled this revision from to Allow lint codes to be up to 128 bytes long.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Sep 25 2015, 5:09 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 25 2015, 5:09 PM
This revision was automatically updated to reflect the committed changes.