Allow Drydock leases to expire after a time limit
ClosedPublic
Actions

Authored by epriestley on Sep 23 2015, 8:16 PM.

Details

Reviewers

hach-que
chad

Maniphest Tasks

T6569: Implement proper expiry mechanism for Drydock resources

Commits

Restricted Diffusion Commit
rP337990423740: Allow Drydock leases to expire after a time limit

Summary

Ref T6569. If a lease is activated with an expiration date, schedule a task to try to clean it up after that time.

Test Plan

Used bin/drydock lease ... --until ... to activate a lease in the near future.
Waited for a bit.
Saw it expire and get destroyed at the scheduled time.

Diff Detail

Repository

rP Phabricator

Branch

drydock4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8033
Build 9098: [Placeholder Plan] Wait for 30 Seconds
Build 9097: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34186.Sep 23 2015, 8:16 PM

epriestley retitled this revision from to Allow Drydock leases to expire after a time limit.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, hach-que.

epriestley added a task: T6569: Implement proper expiry mechanism for Drydock resources.

chad accepted this revision.Sep 23 2015, 8:32 PM

chad edited edge metadata.

chad added inline comments.

src/applications/drydock/management/DrydockManagementLeaseWorkflow.php
18–20	align?

This revision is now accepted and ready to land.Sep 23 2015, 8:32 PM

I'm intentionally moving away from aligning stuff in the middle of blocks because it messes with blame and generally tends to produce churn without much benefit.

(In theory, blame would be smarter, and there is git blame -w which is somewhat smarter, but in practice I think it's easier to just not align things.)

Closed by commit rP337990423740: Allow Drydock leases to expire after a time limit (authored by epriestley, committed by epriestley). · Explain WhySep 23 2015, 8:54 PM

This revision was automatically updated to reflect the committed changes.

artms added a subscriber: artms.Jan 13 2021, 1:34 PM

artms added inline comments.

src/infrastructure/daemon/workers/PhabricatorWorker.php
122	If queue is empty and this is the only task into the queue - it will be immediately executed - is this expected behavior? By default PhabricatorWorkerLeaseQuery fetches unleased tasks which are `leaseOwner IS NULL` (https://secure.phabricator.com/source/phabricator/browse/master/src/infrastructure/daemon/workers/query/PhabricatorWorkerLeaseQuery.php$226), so setting leaseExpire without setting leaseOwner looks like not to yield any delay at all...