Paths

Table of Contentst

Fix an issue with PhutilConsoleTable alignment
ClosedPublic
Actions

Authored by epriestley on Sep 22 2015, 6:59 PM.

Tags

None

Referenced Files

	F13811149: D14141.diff
	Wed, Sep 18, 1:40 AM

	Unknown Object (File)
	Sun, Sep 15, 3:39 PM

	Unknown Object (File)
	Thu, Sep 12, 8:07 AM

	Unknown Object (File)
	Thu, Sep 5, 4:27 PM

	Unknown Object (File)
	Sat, Aug 31, 2:34 PM

	Unknown Object (File)
	Fri, Aug 30, 7:45 PM

	Unknown Object (File)
	Sat, Aug 24, 8:26 AM

	Unknown Object (File)
	Aug 17 2024, 6:49 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rPHUc72eb747e706: Fix an issue with PhutilConsoleTable alignment

Summary

We may try to tsprintf() a complex element if a table is configured for alignment.

Clean this up a bit.

Test Plan

bin/storage adjust no longer warns about aligning a bad column header.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34172.Sep 22 2015, 6:59 PM

epriestley retitled this revision from to Fix an issue with PhutilConsoleTable alignment.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

itsawesome

This revision is now accepted and ready to land.Sep 22 2015, 7:02 PM

Closed by commit rPHUc72eb747e706: Fix an issue with PhutilConsoleTable alignment (authored by epriestley, committed by epriestley). · Explain WhySep 22 2015, 7:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

console/

view/

PhutilConsoleTable.php

14 lines

Diff 34173

View Options

src/console/view/PhutilConsoleTable.php

Fix an issue with PhutilConsoleTable alignmentClosedPublicActions