Paths

Table of Contentst

Fix an issue with PhutilConsoleTable alignment
ClosedPublic
Actions

Authored by epriestley on Sep 22 2015, 6:59 PM.

Tags

None

Referenced Files

	F15408606: D14141.id.diff
	Wed, Mar 19, 12:07 AM

	F15392797: D14141.diff
	Sat, Mar 15, 5:37 PM

	F15380592: D14141.diff
	Fri, Mar 14, 3:47 AM

	F15339013: D14141.id34172.diff
	Mar 9 2025, 2:04 PM

	Unknown Object (File)
	Feb 25 2025, 1:16 AM

	Unknown Object (File)
	Feb 14 2025, 3:41 AM

	Unknown Object (File)
	Feb 9 2025, 9:40 PM

	Unknown Object (File)
	Feb 8 2025, 11:19 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rPHUc72eb747e706: Fix an issue with PhutilConsoleTable alignment

Summary

We may try to tsprintf() a complex element if a table is configured for alignment.

Clean this up a bit.

Test Plan

bin/storage adjust no longer warns about aligning a bad column header.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34172.Sep 22 2015, 6:59 PM

epriestley retitled this revision from to Fix an issue with PhutilConsoleTable alignment.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

itsawesome

This revision is now accepted and ready to land.Sep 22 2015, 7:02 PM

Closed by commit rPHUc72eb747e706: Fix an issue with PhutilConsoleTable alignment (authored by epriestley, committed by epriestley). · Explain WhySep 22 2015, 7:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

console/

view/

PhutilConsoleTable.php

14 lines

Diff 34173

View Options

src/console/view/PhutilConsoleTable.php

Fix an issue with PhutilConsoleTable alignmentClosedPublicActions