Page MenuHomePhabricator
Differential D14120

More ActionPanel colors, hardening
ClosedPublic
Actions

Authored by chad on Sep 16 2015, 4:20 PM.
Tags
None
Referenced Files
F13816892: D14120.diff
Thu, Sep 19, 7:52 PM
Unknown Object (File)
Sun, Sep 15, 9:31 PM
Unknown Object (File)
Thu, Sep 12, 8:06 AM
Unknown Object (File)
Tue, Sep 10, 2:27 AM
Unknown Object (File)
Thu, Sep 5, 4:18 PM
Unknown Object (File)
Wed, Sep 4, 11:14 AM
Unknown Object (File)
Wed, Sep 4, 11:07 AM
Unknown Object (File)
Wed, Sep 4, 11:06 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP23b2653f52cd: More ActionPanel colors, hardening
Summary

Adds full ROYGBIVP color spectrum, adds basic overflow, collapse protection.

Test Plan

Review small and large panels are various breakpoints.

Diff Detail

Repository
rP Phabricator
Branch
panel-2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7994
Build 9018: [Placeholder Plan] Wait for 30 Seconds
Build 9017: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 34113.Sep 16 2015, 4:20 PM
chad retitled this revision from to More ActionPanel colors, hardening.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 16 2015, 4:20 PM
epriestley accepted this revision.Sep 16 2015, 4:21 PM
epriestley edited edge metadata.

wow such color

This revision is now accepted and ready to land.Sep 16 2015, 4:21 PM
Closed by commit rP23b2653f52cd: More ActionPanel colors, hardening (authored by chad, committed by chad). · Explain WhySep 16 2015, 4:22 PM
This revision was automatically updated to reflect the committed changes.
johnny-bit mentioned this in T9432: Build a DashboardPanel around PHUIActionPanelView.Sep 16 2015, 6:47 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
uiexample/
examples/
15 lines
view/
phui/
14 lines
webroot/
rsrc/
css/
phui/
117 lines

Diff 34113

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/uiexample/examples/PHUIActionPanelExample.php

Loading...
View Options

src/view/phui/PHUIActionPanelView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-action-panel.css

Loading...
Phabricator · Built by Phacility