Page MenuHomePhabricator

Add `bin/auth unlimit` and clean up a TODO
ClosedPublic

Authored by epriestley on Sep 13 2015, 10:41 PM.
Tags
None
Referenced Files
F15663709: D14105.diff
Sat, May 24, 10:02 PM
Unknown Object (File)
Apr 22 2025, 2:19 AM
Unknown Object (File)
Apr 17 2025, 2:34 AM
Unknown Object (File)
Apr 17 2025, 2:33 AM
Unknown Object (File)
Apr 17 2025, 2:33 AM
Unknown Object (File)
Apr 17 2025, 2:33 AM
Unknown Object (File)
Apr 4 2025, 2:34 AM
Unknown Object (File)
Mar 30 2025, 3:59 PM
Subscribers

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP0449a07f537d: Add `bin/auth unlimit` and clean up a TODO
Summary

I stumbled across this TODO and was worried that there was a glaring hole in MFA that I'd somehow forgotten about, but the TODO is just out of date.

These actions are rate limited properly by PhabricatorAuthTryFactorAction, which permits a maximum of 10 actions per hour.

  • Remove the TODO.
  • Add bin/auth unlimit to make it easier to reset rate limits if someone needs to do that for whatever reason.
Test Plan
  • Tried to brute force through MFA.
  • Got rate limited properly after 10 failures.
  • Reset rate limit with bin/auth unlimit.
  • Saw the expected number of actions clear.

Screen Shot 2015-09-13 at 3.31.49 PM.png (940×1 px, 149 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add `bin/auth unlimit` and clean up a TODO.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 14 2015, 1:22 AM
joshuaspence added inline comments.
src/applications/auth/management/PhabricatorAuthManagementUnlimitWorkflow.php
34

--user should be parameterized.

55

As above.

This revision was automatically updated to reflect the committed changes.