Page MenuHomePhabricator
Differential D14094

Show users what's wrong when they try to edit an inline with an editor already open
ClosedPublic
Actions

Authored by epriestley on Sep 10 2015, 6:19 PM.
Tags
None
Referenced Files
F14029494: D14094.id34064.diff
Fri, Nov 8, 8:45 PM
F14029491: D14094.id34063.diff
Fri, Nov 8, 8:45 PM
F14029489: D14094.id.diff
Fri, Nov 8, 8:45 PM
F14029488: D14094.diff
Fri, Nov 8, 8:45 PM
F14014678: D14094.id34064.diff
Sun, Nov 3, 6:40 AM
F14009424: D14094.id34063.diff
Wed, Oct 30, 5:07 PM
F13995999: D14094.id.diff
Wed, Oct 23, 5:12 PM
F13991805: D14094.id34063.diff
Tue, Oct 22, 12:53 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8572: Prompt for incomplete/unsaved inline comments upon creating a new comment instead of doing nothing
Commits
Restricted Diffusion Commit
rP093a6256984c: Show users what's wrong when they try to edit an inline with an editor…
Summary

Fixes T8572. Ideally we would probably just permit this, but clean up the behavior until the day arrives when inline code is actually rewritten.

Test Plan
  • Tried to launch editors in Differential and Diffusion while comments were already open.
  • Verified that "Jump to inline" works in both cases.

Screen Shot 2015-09-10 at 11.17.12 AM.png (1×1 px, 205 KB)

Screen Shot 2015-09-10 at 11.17.16 AM.png (1×1 px, 207 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34063.Sep 10 2015, 6:19 PM
epriestley retitled this revision from to Show users what's wrong when they try to edit an inline with an editor already open.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8572: Prompt for incomplete/unsaved inline comments upon creating a new comment instead of doing nothing.
chad accepted this revision.Sep 10 2015, 6:27 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 10 2015, 6:27 PM
Closed by commit rP093a6256984c: Show users what's wrong when they try to edit an inline with an editor… (authored by epriestley, committed by epriestley). · Explain WhySep 10 2015, 6:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
42 lines
src/
infrastructure/
diff/
13 lines
webroot/
rsrc/
js/
application/
differential/
22 lines
16 lines

Diff 34064

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
View Options

webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js

Loading...
Phabricator · Built by Phacility