Paths

Table of Contentst

Differential D14086

Add Maniphest Task email creator to CCs
ClosedPublic
Actions

Authored by epriestley on Sep 9 2015, 8:11 PM.

Tags

None

Referenced Files

	F14011309: D14086.id34049.diff
	Thu, Oct 31, 10:52 PM

	F14011308: D14086.id34046.diff
	Thu, Oct 31, 10:52 PM

	F14011307: D14086.id34044.diff
	Thu, Oct 31, 10:52 PM

	F14011306: D14086.id.diff
	Thu, Oct 31, 10:52 PM

	F14009717: D14086.diff
	Wed, Oct 30, 11:07 PM

	F13995224: D14086.diff
	Wed, Oct 23, 11:28 AM

	F13979835: D14086.diff
	Sat, Oct 19, 6:48 AM

	F13976867: D14086.id.diff
	Fri, Oct 18, 4:03 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T9369: Author of email not added to maniphest subscribers

Commits

Restricted Diffusion Commit
rPde01f3e2e08e: Add Maniphest Task email creator to CCs

Summary

Fixes T9369.

Test Plan

Sent a mail with Mail.app to bugs@local.phacility.com.
Used "View Raw Mail", copy-pasted it into mail.txt on disk.
Ran cat mail.txt | ./scripts/mail/manage_mail.php --process-duplicates.
Saw task get created and me get added as CC.
Changed "To" to include another user, ran command again, saw task get created and other user get added as CC.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34044.Sep 9 2015, 8:11 PM

chad retitled this revision from to Add Maniphest Task email creator to CCs.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9369: Author of email not added to maniphest subscribers.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 9 2015, 8:11 PM

This won't actually apply the transaction and $sender may not have a real PHID, let me poke this and kick it back to you.

I assumed this was automatic in ManiphestTask, but in the edit page we set it by hand.

epriestley updated this object.Sep 9 2015, 8:57 PM

epriestley edited the test plan for this revision. (Show Details)

epriestley edited edge metadata.

For Maniphest, add author as subscriber.
Fix "subscribe all To/Cc" which got derped up a while ago (this is presumably rarely used).
Some minor cleanup.

thx u :3

Nice test plan, need to save that info.

This revision is now accepted and ready to land.Sep 9 2015, 9:04 PM

Closed by commit rPde01f3e2e08e: Add Maniphest Task email creator to CCs (authored by epriestley, committed by epriestley). · Explain WhySep 9 2015, 9:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

mail/

ConpherenceCreateThreadMailReceiver.php

2 lines

maniphest/

mail/

ManiphestCreateMailReceiver.php

2 lines

ManiphestReplyHandler.php

15 lines

metamta/

receiver/

PhabricatorObjectMailReceiver.php

2 lines

storage/

PhabricatorMetaMTAReceivedMail.php

2 lines

transactions/

replyhandler/

PhabricatorApplicationTransactionReplyHandler.php

8 lines

Diff 34049

src/applications/conpherence/mail/ConpherenceCreateThreadMailReceiver.php

Loading...

src/applications/maniphest/mail/ManiphestCreateMailReceiver.php

Loading...

src/applications/maniphest/mail/ManiphestReplyHandler.php

Loading...

src/applications/metamta/receiver/PhabricatorObjectMailReceiver.php

Loading...

src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php

Loading...

src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php

Loading...