Page MenuHomePhabricator
Differential D14086

Add Maniphest Task email creator to CCs
ClosedPublic
Actions

Authored by epriestley on Sep 9 2015, 8:11 PM.
Tags
None
Referenced Files
F13813546: D14086.id34046.diff
Wed, Sep 18, 11:37 PM
F13813545: D14086.id34044.diff
Wed, Sep 18, 11:37 PM
Unknown Object (File)
Thu, Sep 12, 8:05 AM
Unknown Object (File)
Thu, Sep 12, 8:05 AM
Unknown Object (File)
Wed, Sep 11, 12:19 PM
Unknown Object (File)
Wed, Sep 11, 12:10 PM
Unknown Object (File)
Wed, Sep 11, 12:09 PM
Unknown Object (File)
Wed, Sep 11, 12:06 PM
View All Files
Subscribers
Korvin

Details

Reviewers
chad
Maniphest Tasks
T9369: Author of email not added to maniphest subscribers
Commits
Restricted Diffusion Commit
rPde01f3e2e08e: Add Maniphest Task email creator to CCs
Summary

Fixes T9369.

Test Plan
  • Sent a mail with Mail.app to bugs@local.phacility.com.
  • Used "View Raw Mail", copy-pasted it into mail.txt on disk.
  • Ran cat mail.txt | ./scripts/mail/manage_mail.php --process-duplicates.
  • Saw task get created and me get added as CC.
  • Changed "To" to include another user, ran command again, saw task get created and other user get added as CC.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34044.Sep 9 2015, 8:11 PM
chad retitled this revision from to Add Maniphest Task email creator to CCs.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T9369: Author of email not added to maniphest subscribers.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 9 2015, 8:11 PM
epriestley commandeered this revision.Sep 9 2015, 8:30 PM
epriestley edited reviewers, added: chad; removed: epriestley.

This won't actually apply the transaction and $sender may not have a real PHID, let me poke this and kick it back to you.

chad edited edge metadata.Sep 9 2015, 8:31 PM

I assumed this was automatic in ManiphestTask, but in the edit page we set it by hand.

epriestley updated this object.Sep 9 2015, 8:57 PM
epriestley edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.
epriestley updated this revision to Diff 34046.Sep 9 2015, 8:57 PM
  • For Maniphest, add author as subscriber.
  • Fix "subscribe all To/Cc" which got derped up a while ago (this is presumably rarely used).
  • Some minor cleanup.
chad accepted this revision.Sep 9 2015, 9:04 PM
chad edited edge metadata.

thx u :3

Nice test plan, need to save that info.

This revision is now accepted and ready to land.Sep 9 2015, 9:04 PM
Closed by commit rPde01f3e2e08e: Add Maniphest Task email creator to CCs (authored by epriestley, committed by epriestley). · Explain WhySep 9 2015, 9:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
mail/
2 lines
maniphest/
mail/
2 lines
15 lines
metamta/
receiver/
2 lines
storage/
2 lines
transactions/
replyhandler/
8 lines

Diff 34049

View Options

src/applications/conpherence/mail/ConpherenceCreateThreadMailReceiver.php

Loading...
View Options

src/applications/maniphest/mail/ManiphestCreateMailReceiver.php

Loading...
View Options

src/applications/maniphest/mail/ManiphestReplyHandler.php

Loading...
View Options

src/applications/metamta/receiver/PhabricatorObjectMailReceiver.php

Loading...
View Options

src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php

Loading...
View Options

src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php

Loading...
Phabricator · Built by Phacility