Page MenuHomePhabricator
Differential D14059

Build LauncherButton for PHUIObjectItemView
ClosedPublic
Actions

Authored by chad on Sep 4 2015, 5:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 7:23 PM
Unknown Object (File)
Sun, Apr 14, 11:38 PM
Unknown Object (File)
Wed, Apr 3, 11:15 AM
Unknown Object (File)
Wed, Apr 3, 11:15 AM
Unknown Object (File)
Wed, Apr 3, 11:15 AM
Unknown Object (File)
Mon, Apr 1, 3:28 PM
Unknown Object (File)
Sun, Mar 31, 2:36 PM
Unknown Object (File)
Tue, Mar 26, 3:47 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9342: Make it easier to discover application policy configuration
Commits
Restricted Diffusion Commit
rP7641c9c7bc01: Build LauncherButton for PHUIObjectItemView
Summary

There are a handful of places I've been wanting to use a button here. Adds that ability and uses in app launcher.

Test Plan

Test Applicatons->Launcher at desktop, mobile, tablet breakpoints

pasted_file (478×840 px, 71 KB)

Diff Detail

Repository
rP Phabricator
Branch
launcher
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7914
Build 8857: [Placeholder Plan] Wait for 30 Seconds
Build 8856: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33988.Sep 4 2015, 5:30 PM
chad retitled this revision from to Build LauncherButton for PHUIObjectItemView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 4 2015, 5:30 PM
chad edited the test plan for this revision. (Show Details)Sep 4 2015, 5:31 PM
epriestley accepted this revision.Sep 4 2015, 5:33 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/meta/query/PhabricatorAppSearchEngine.php
234

Maybe just call this "Configure"? The "Configure / Help" feels a touch weird.

This revision is now accepted and ready to land.Sep 4 2015, 5:33 PM
Closed by commit rP7641c9c7bc01: Build LauncherButton for PHUIObjectItemView (authored by chad, committed by chad). · Explain WhySep 4 2015, 5:34 PM
This revision was automatically updated to reflect the committed changes.
chad added a task: T9342: Make it easier to discover application policy configuration.Sep 4 2015, 6:13 PM
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
src/
applications/
meta/
query/
39 lines
view/
phui/
18 lines
webroot/
rsrc/
css/
phui/
13 lines

Diff 33988

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/meta/query/PhabricatorAppSearchEngine.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...
Phabricator · Built by Phacility