Page MenuHomePhabricator

Modernize OAuthserver and provide more context on "no permission" exception
ClosedPublic

Authored by epriestley on Sep 3 2015, 3:47 PM.

Details

Summary

Ref T7173. Depends on D14049. Now that Phacility can install custom exception handlers, this puts enough information on the exception so that we can figure out what to do with it.

  • Generally modernize some of this code.
  • Add some more information to PolicyExceptions so the new RequestExceptionHandler can handle them properly.
Test Plan

Failed authorizations, then succeeded authorizations. See next diff.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 33959.Sep 3 2015, 3:47 PM
epriestley retitled this revision from to Modernize OAuthserver and provide more context on "no permission" exception.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a child revision: Restricted Differential Revision.Sep 3 2015, 3:50 PM
chad accepted this revision.Sep 3 2015, 4:05 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 3 2015, 4:05 PM
epriestley updated this revision to Diff 33962.Sep 3 2015, 4:11 PM
epriestley edited edge metadata.
  • Fix an unrelated Fund issue with handling of bad data.
  • Provide a little more context on policy exceptions.
This revision was automatically updated to reflect the committed changes.