Page MenuHomePhabricator

Modernize OAuthserver and provide more context on "no permission" exception
ClosedPublic

Authored by epriestley on Sep 3 2015, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 4:54 AM
Unknown Object (File)
Sat, Mar 23, 4:13 PM
Unknown Object (File)
Tue, Mar 12, 9:17 PM
Unknown Object (File)
Tue, Mar 12, 6:18 PM
Unknown Object (File)
Tue, Mar 12, 5:31 PM
Unknown Object (File)
Tue, Mar 12, 2:13 PM
Unknown Object (File)
Mon, Mar 11, 9:30 AM
Unknown Object (File)
Mon, Mar 11, 9:30 AM
Subscribers
None

Details

Summary

Ref T7173. Depends on D14049. Now that Phacility can install custom exception handlers, this puts enough information on the exception so that we can figure out what to do with it.

  • Generally modernize some of this code.
  • Add some more information to PolicyExceptions so the new RequestExceptionHandler can handle them properly.
Test Plan

Failed authorizations, then succeeded authorizations. See next diff.

Diff Detail

Repository
rP Phabricator
Branch
gripe5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7903
Build 8837: [Placeholder Plan] Wait for 30 Seconds
Build 8836: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modernize OAuthserver and provide more context on "no permission" exception.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a child revision: Restricted Differential Revision.Sep 3 2015, 3:50 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 3 2015, 4:05 PM
epriestley edited edge metadata.
  • Fix an unrelated Fund issue with handling of bad data.
  • Provide a little more context on policy exceptions.
This revision was automatically updated to reflect the committed changes.