Page MenuHomePhabricator

Allow Controllers to return a wider range of "response-like" objects
ClosedPublic

Authored by epriestley on Sep 1 2015, 5:26 PM.

Details

Summary

Ref T1806. Ref T5752. Currently, handleRequest() needs to return an AphrontResponse, but sometimes it's really convenient to return some other object, like a Dialog, and let that convert into a response elsewhere.

Formalize this and clean up some of the existing hacks for it so there's less custom/magical code in Phabricator-specific classes and more general code in Aphront classes.

More broadly, I want to clean up T5752 before pursuing T9132, since I'm generally happy with how SearchEngine works except for how it interacts with side navs / application menus. I want to fix that first so a new Editor (which will have a lot in common with SearchEngine in terms of how controllers interact with it) doesn't make the problem twice as bad.

Test Plan
  • Loaded a bunch of normal pages.
  • Loaded dialogs.
  • Loaded proxy responses (submitted empty comments in Maniphest).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow Controllers to return a wider range of "response-like" objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
joshuaspence added inline comments.
src/aphront/configuration/AphrontApplicationConfiguration.php
483

Opyt

src/aphront/interface/AphrontResponseProducerInterface.php
14

Personally I feel that naming an interface with Interface is odd.

chad edited edge metadata.
This revision is now accepted and ready to land.Sep 1 2015, 10:38 PM
This revision was automatically updated to reflect the committed changes.