HomePhabricator

Use phutil_hashes_are_identical() when comparing hashes in Phabricator

Description

Use phutil_hashes_are_identical() when comparing hashes in Phabricator

Summary: See D14025. In all cases where we compare hashes, use strict, constant-time comparisons.

Test Plan: Logged in, logged out, added TOTP, ran Conduit, terminated sessions, submitted forms, changed password. Tweaked CSRF token, got rejected.

Reviewers: chad

Reviewed By: chad

Subscribers: chenxiruanhai

Differential Revision: https://secure.phabricator.com/D14026

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Sep 1 2015, 10:52 PM
Reviewer
chad
Differential Revision
D14026: Use phutil_hashes_are_identical() when comparing hashes in Phabricator
Parents
rP13516cf35f03: Fix an issue with "packages(...)" in typeaheads
Branches
Unknown
Tags
Unknown