Differential D14015

Fix permission check for "Create Task" on workboards
ClosedPublic
Actions

Authored by epriestley on Aug 31 2015, 2:11 PM.

Details

Reviewers

chad

Maniphest Tasks

T9090: Create task button is greyed out

Commits

Restricted Diffusion Commit
rPe9614df76e0b: Fix permission check for "Create Task" on workboards

Summary

Fixes T9090. You don't need to be able to edit a project to create tasks on its workboard. Being able to view the project is sufficient, and the user certianly can if they got this far.

Test Plan

Viewed workboard, hit "Create Task".

Diff Detail

Repository

rP Phabricator

Branch

wperm1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7856
Build 8743: [Placeholder Plan] Wait for 30 Seconds
Build 8742: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33891.Aug 31 2015, 2:11 PM

epriestley retitled this revision from to Fix permission check for "Create Task" on workboards.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9090: Create task button is greyed out.

chad accepted this revision.Aug 31 2015, 2:29 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 31 2015, 2:29 PM

Closed by commit rPe9614df76e0b: Fix permission check for "Create Task" on workboards (authored by epriestley, committed by epriestley). · Explain WhyAug 31 2015, 5:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectBoardViewController.php

3 lines

Diff 33891

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Fix permission check for "Create Task" on workboardsClosedPublicActions