Page MenuHomePhabricator

Web Push notifications
Needs ReviewPublic

Authored by duraseb on Aug 30 2015, 4:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 11:32 AM
Unknown Object (File)
Thu, Apr 11, 7:53 AM
Unknown Object (File)
Fri, Mar 29, 5:33 AM
Unknown Object (File)
Thu, Mar 28, 9:00 AM
Unknown Object (File)
Sat, Mar 23, 8:02 AM
Unknown Object (File)
Feb 14 2024, 6:51 AM
Unknown Object (File)
Feb 3 2024, 6:27 AM
Unknown Object (File)
Jan 28 2024, 5:47 PM

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8924: Add push notification support
Summary

refs T8924

This is a proposed solution for Web Push notifications for Phabricator.
Supported apps: Conpherence

Later improvements:

  • display details in notifications instead of the generic information
  • clicking on the notification should open conpherence chat page
  • only send push notifications if a user has been inactive for some time
  • wait for Firefox support not to be that flaky
Test Plan

Diff Detail

Repository
rP Phabricator
Branch
webpush-notifications
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/webpush/controller/PhabricatorManifestController.php:12TXT3Line Too Long
Warningsrc/applications/webpush/settings/PhabricatorWebpushNotificationsSettingsPanel.php:22TXT3Line Too Long
Warningsrc/applications/webpush/settings/PhabricatorWebpushNotificationsSettingsPanel.php:22XHP36Slow Construct
Warningsrc/applications/webpush/settings/PhabricatorWebpushNotificationsSettingsPanel.php:159TXT3Line Too Long
Warningsrc/applications/webpush/settings/PhabricatorWebpushNotificationsSettingsPanel.php:177TXT3Line Too Long
Warningwebroot/rsrc/js/application/config/webpush-subscriptions.js:1JAVELIN5`javelinsymbols` Not In Path
Warningwebroot/rsrc/js/application/config/webpush-subscriptions.js:8W117JSHintW117
Warningwebroot/rsrc/js/application/config/webpush-subscriptions.js:23W117JSHintW117
Warningwebroot/rsrc/js/application/config/webpush-subscriptions.js:28TXT3Line Too Long
Warningwebroot/rsrc/js/application/config/webpush-subscriptions.js:29W117JSHintW117
Warningwebroot/rsrc/js/application/config/webpush-subscriptions.js:31TXT3Line Too Long
Warningwebroot/rsrc/js/application/config/webpush-subscriptions.js:42W117JSHintW117
Warningwebroot/rsrc/js/application/config/webpush-subscriptions.js:48W117JSHintW117
Warningwebroot/rsrc/js/application/config/webpush-subscriptions.js:60W117JSHintW117
Warningwebroot/rsrc/js/core/ServiceWorker.js:5W117JSHintW117
Warningwebroot/rsrc/js/core/ServiceWorker.js:6W098JSHintW098
Warningwebroot/rsrc/js/core/ServiceWorker.js:6W117JSHintW117
Warningwebroot/rsrc/js/core/ServiceWorker.js:7W117JSHintW117
Warningwebroot/rsrc/js/core/ServiceWorker.js:8TXT3Line Too Long
Warningwebroot/rsrc/js/core/ServiceWorker.js:14W117JSHintW117
Warningwebroot/rsrc/js/core/ServiceWorker.js:19W117JSHintW117
Warningwebroot/rsrc/js/core/ServiceWorker.js:21W117JSHintW117
Warningwebroot/rsrc/js/core/ServiceWorker.js:22W117JSHintW117
Warningwebroot/rsrc/js/core/ServiceWorker.js:26W117JSHintW117
Warningwebroot/rsrc/js/core/ServiceWorker.js:30W117JSHintW117
Unit
Tests Passed
Build Status
Buildable 7846
Build 8723: [Placeholder Plan] Wait for 30 Seconds
Build 8722: arc lint + arc unit