Paths

Table of Contentst

Differential D14011

Web Push notifications
Needs ReviewPublic
Actions

Authored by duraseb on Aug 30 2015, 4:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 28, 5:26 PM

	Unknown Object (File)
	Mon, Jan 27, 9:16 AM

	Unknown Object (File)
	Sun, Jan 26, 2:48 PM

	Unknown Object (File)
	Sun, Jan 26, 2:48 PM

	Unknown Object (File)
	Sun, Jan 26, 2:48 PM

	Unknown Object (File)
	Thu, Jan 23, 6:30 PM

	Unknown Object (File)
	Tue, Jan 21, 3:10 PM

	Unknown Object (File)
	Sat, Jan 18, 6:56 AM

Subscribers

tycho.tatitscheff

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8924: Add push notification support

Summary

refs T8924

This is a proposed solution for Web Push notifications for Phabricator.
Supported apps: Conpherence

Later improvements:

display details in notifications instead of the generic information
clicking on the notification should open conpherence chat page
only send push notifications if a user has been inactive for some time
wait for Firefox support not to be that flaky

Test Plan

run phabricator on a secure url
create a project in https://console.developers.google.com/project
enable GCM and set project ID and API key to webpush.gcm-sender-id and webpush.gcm-api-key respectively

Diff Detail

Repository

Branch

webpush-notifications

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	webroot/rsrc/js/application/config/webpush-subscriptions.js:1	JAVELIN5	`javelinsymbols` Not In Path
Warning	webroot/rsrc/js/application/config/webpush-subscriptions.js:8	W117	JSHintW117
Warning	webroot/rsrc/js/application/config/webpush-subscriptions.js:40	W117	JSHintW117
Warning	webroot/rsrc/js/application/config/webpush-subscriptions.js:47	W117	JSHintW117
Warning	webroot/rsrc/js/application/config/webpush-subscriptions.js:61	W117	JSHintW117
Warning	webroot/rsrc/js/application/config/webpush-subscriptions.js:67	W117	JSHintW117
Warning	webroot/rsrc/js/application/config/webpush-subscriptions.js:79	W117	JSHintW117
Warning	webroot/rsrc/js/core/ServiceWorker.js:5	W117	JSHintW117
Warning	webroot/rsrc/js/core/ServiceWorker.js:6	W098	JSHintW098
Warning	webroot/rsrc/js/core/ServiceWorker.js:6	W117	JSHintW117
Warning	webroot/rsrc/js/core/ServiceWorker.js:7	W117	JSHintW117
Warning	webroot/rsrc/js/core/ServiceWorker.js:15	W117	JSHintW117
Warning	webroot/rsrc/js/core/ServiceWorker.js:20	W117	JSHintW117
Warning	webroot/rsrc/js/core/ServiceWorker.js:22	W117	JSHintW117
Warning	webroot/rsrc/js/core/ServiceWorker.js:23	W117	JSHintW117
Warning	webroot/rsrc/js/core/ServiceWorker.js:27	W117	JSHintW117
Warning	webroot/rsrc/js/core/ServiceWorker.js:31	W117	JSHintW117

Unit

Tests Passed

Build Status

Buildable 7848
Build 8727: [Placeholder Plan] Wait for 30 Seconds
Build 8726: arc lint + arc unit

Event Timeline

duraseb updated this revision to Diff 33877.Aug 30 2015, 4:12 PM

duraseb retitled this revision from to Web Push notifications.

duraseb updated this object.

duraseb edited the test plan for this revision. (Show Details)

duraseb added reviewers: chad, epriestley.

duraseb added a task: T8924: Add push notification support.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 30 2015, 4:12 PM

Herald added a subscriber: Korvin. · View Herald Transcript

Improved subscription form handling
Linter reported fixes

tycho.tatitscheff added a subscriber: tycho.tatitscheff.Aug 30 2015, 10:42 PM

• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM

chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

joshuaspence added a subscriber: joshuaspence.Nov 13 2015, 9:19 PM

ProfFan added a subscriber: ProfFan.Feb 27 2016, 6:43 AM

• pasik added a subscriber: • pasik.May 3 2018, 4:14 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

resources/

celerity/

9 lines

100%

Loading...

sql/

autopatches/

20150828.webpush.create.sql

11 lines

-

-

src/

__phutil_library_map__.php

16 lines

-

-

aphront/

response/

AphrontJavascriptResponse.php

24 lines

25%

Loading...

applications/

conpherence/

editor/

ConpherenceEditor.php

9 lines

69%

Loading...

people/

editor/

PhabricatorUserEditor.php

87 lines

11%

Loading...

storage/

PhabricatorUserLog.php

5 lines

39%

Loading...

webpush/

application/

PhabricatorWebpushApplication.php

28 lines

0%

Loading...

client/

PhabricatorWebpushClient.php

83 lines

48%

Loading...

config/

PhabricatorWebpushConfigOptions.php

46 lines

0%

Loading...

controller/

PhabricatorManifestController.php

36 lines

9%

Loading...

PhabricatorServiceworkerController.php

19 lines

22%

Loading...

settings/

PhabricatorWebpushNotificationsSettingsPanel.php

230 lines

1%

Loading...

storage/

PhabricatorUserWebPushSubscriber.php

33 lines

13%

Loading...

view/

page/

PhabricatorBarePageView.php

11 lines

2%

Loading...

webroot/

rsrc/

js/

application/

config/

webpush-subscriptions.js

107 lines

-

-

core/

ServiceWorker.js

33 lines

-

-

Diff 33879

resources/celerity/map.php

Loading...

resources/sql/autopatches/20150828.webpush.create.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/aphront/response/AphrontJavascriptResponse.php

Loading...

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...

src/applications/people/editor/PhabricatorUserEditor.php

Loading...

src/applications/people/storage/PhabricatorUserLog.php

Loading...

src/applications/webpush/application/PhabricatorWebpushApplication.php

Loading...

src/applications/webpush/client/PhabricatorWebpushClient.php

Loading...

src/applications/webpush/config/PhabricatorWebpushConfigOptions.php

Loading...

src/applications/webpush/controller/PhabricatorManifestController.php

Loading...

src/applications/webpush/controller/PhabricatorServiceworkerController.php

Loading...

src/applications/webpush/settings/PhabricatorWebpushNotificationsSettingsPanel.php

Loading...

src/applications/webpush/storage/PhabricatorUserWebPushSubscriber.php

Loading...

src/view/page/PhabricatorBarePageView.php

Loading...

webroot/rsrc/js/application/config/webpush-subscriptions.js

Loading...

webroot/rsrc/js/core/ServiceWorker.js

Loading...