Page MenuHomePhabricator
Differential D14003

Basic Answer Wiki for Ponder
ClosedPublic
Actions

Authored by chad on Aug 29 2015, 1:50 AM.
Tags
None
Referenced Files
F14475729: D14003.id33847.diff
Fri, Dec 27, 8:40 PM
Unknown Object (File)
Tue, Dec 24, 1:35 PM
Unknown Object (File)
Sun, Dec 22, 2:01 PM
Unknown Object (File)
Wed, Dec 18, 5:57 AM
Unknown Object (File)
Sun, Dec 15, 11:46 PM
Unknown Object (File)
Sat, Dec 14, 7:28 AM
Unknown Object (File)
Fri, Dec 13, 1:40 PM
Unknown Object (File)
Wed, Dec 11, 2:13 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP2665970762bf: Basic Answer Wiki for Ponder
Summary

Adds an additional field for questions, an answer wiki, should should usually be community editable.

Test Plan

New question, edit question, no wiki, lots of wiki.

Diff Detail

Repository
rP Phabricator
Branch
ponder-answer-wiki
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7829
Build 8690: [Placeholder Plan] Wait for 30 Seconds
Build 8689: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33847.Aug 29 2015, 1:50 AM
chad retitled this revision from to Basic Answer Wiki for Ponder.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 29 2015, 1:50 AM
chad updated this revision to Diff 33848.Aug 29 2015, 1:53 AM
  • add answer preview to edit form
epriestley accepted this revision.Aug 29 2015, 3:27 PM
epriestley edited edge metadata.

Calling this an "answer wiki" instead of a "summary" or something feels slightly odd to me -- Quora uses this term, but I don't think other things do, and it maybe risks confusion with Phriction here. But this is pretty fluff. Code itself looks good to me.

resources/sql/autopatches/20150828.ponder.wiki.1.sql
2

This should have ... LONGTEXT COLLATE {$COLLATE_TEXT} NOT NULL

src/applications/ponder/storage/PonderQuestionTransaction.php
177

ANSWERWIKI should probably be here too so users can get a dialog with diffs when the thing is edited.

This revision is now accepted and ready to land.Aug 29 2015, 3:27 PM
chad planned changes to this revision.Aug 29 2015, 3:35 PM
chad updated this revision to Diff 33862.Aug 29 2015, 8:54 PM
chad marked 2 inline comments as done.
chad edited edge metadata.
  • add answer preview to edit form
  • Update to Answer Summary in copy
This revision is now accepted and ready to land.Aug 29 2015, 8:54 PM
chad updated this revision to Diff 33863.Aug 29 2015, 8:56 PM
  • Make the summary blue
Closed by commit rP2665970762bf: Basic Answer Wiki for Ponder (authored by chad, committed by chad). · Explain WhyAug 29 2015, 8:59 PM
This revision was automatically updated to reflect the committed changes.
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM
chad mentioned this in Z1336: General Chat.Sep 29 2016, 2:32 AM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
applications/
ponder/
controller/
22 lines
9 lines
editor/
8 lines
storage/
2 lines
13 lines

Diff 33848

View Options

resources/sql/autopatches/20150828.ponder.wiki.1.sql

Loading...
View Options

src/applications/ponder/controller/PonderQuestionEditController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...
View Options

src/applications/ponder/editor/PonderQuestionEditor.php

Loading...
View Options

src/applications/ponder/storage/PonderQuestion.php

Loading...
View Options

src/applications/ponder/storage/PonderQuestionTransaction.php

Loading...
Phabricator · Built by Phacility